Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NcDateTimePicker): improve design and make it consistent with Nc 30 #6125

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

st3iny
Copy link
Contributor

@st3iny st3iny commented Sep 30, 2024

☑️ Resolves

🖼️ Screenshots

Date picker

(Also take note of the confirm button hover state.)

🏚️ Before 🏡 After
grafik grafik
grafik grafik

Month picker

🏚️ Before 🏡 After
grafik grafik

Year picker

🏚️ Before 🏡 After
grafik grafik

Time picker

🏚️ Before 🏡 After
grafik grafik

🏁 Checklist

  • ⛑️ Tests are included or are not applicable
  • 📘 Component documentation has been extended, updated or is not applicable
  • 3️⃣ Backport to next requested with a Vue 3 upgrade

@st3iny st3iny added 3. to review Waiting for reviews feature: datepicker Related to the date/time picker component design Design, UX, interface and interaction design labels Sep 30, 2024
@st3iny st3iny self-assigned this Sep 30, 2024
@st3iny
Copy link
Contributor Author

st3iny commented Sep 30, 2024

/backport to next

Copy link

@nimishavijay nimishavijay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Looks super nice! :) only some small points:

  • in the month and year pickers, the height of each item seems big. It could be the default clickable area
  • The left and right arrows in the month and year pickers can also be just single arrows instead of double
  • The heading for the year picker (2020-2029) should be bold to be consistent with the other headings
  • Instead of "2020~2029" it can say "2020-2029"
  • Nice-to-have: for the time picker there have been some complaints about the "Pick a date" button being unintuitive, people try clicking on the date at the top to go to the date picker. If it would be possible to remove the "Pick a date" button and instead have the date picker open upon clicking the date on top then that would be great :)

Other than that it looks amazing 🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request design Design, UX, interface and interaction design feature: datepicker Related to the date/time picker component
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants