fix(NcRichText): debounce the update of widget visibility #6069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- IntersectionObserver triggered if any pixel of observed element appears in viewport for a moment - with debouncing the update, it won't be triggered during programmatic smooth scroll (less than 100ms in viewport with this commit) Signed-off-by: Maksim Sukharev <[email protected]>
Antreesy
added
bug
|
At this point, we have created different types of scrolling handling due to height changes of We can know which type it will be from the URL. This will make messages list less jumpy, more organized (same height for all external link previews) and reduce a lot of scrolling handling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖼️ Screenshots
🏚️ Before
2024-09-10_14h16_35.mp4
🏡 After
2024-09-10_14h12_59.mp4
🏁 Checklist
nextrequested with a Vue 3 upgrade