refactor: Scope package into modules #1025
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This splits the package into two modules: 1. The default one (`@nextcloud/files`) which provides general utils to work with files or the files app 2. DAV utils (`@nextcloud/files/dav`) which provides WebDAV related utils For legacy reasons to not make this a breaking release the DAV utils are exported with their prefixed names in the default module, but this will be then removed with the next major version. Signed-off-by: Ferdinand Thiessen <[email protected]>
Bundle ReportChanges will increase total bundle size by 3.67kB ⬆️
|
|
I would still prefer do a breaking release and push this for nc 31 and above? :) |
Sure I just wanted to make it non breaking so we might can keep compatible library versions longer for NC releases. |
I personally don't mind both. |
skjnldsv
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do you think of this idea?
This splits the package into two modules:
@nextcloud/files) which provides general utils to work with files or the files app@nextcloud/files/dav) which provides WebDAV related utilsFor legacy reasons to not make this a breaking release the DAV utils are exported with their prefixed names in the default module, but this will be then removed with the next major version.