fix: fileid definition and fallback

Signed-off-by: John Molakvoæ <[email protected]>

__tests__/files/node.spec.ts

@@ -8,23 +8,23 @@ describe('Node testing', () => {
 		const file = new File({
 			source: 'https://cloud.domain.com/remote.php/dav/picture.jpg',
 			mime: 'image/jpeg',
-			owner: 'emma'
+			owner: 'emma',
 		})
 		expect(file.root).toBeNull()
 	})
 
 	test('Remove source ending slash', () => {
 		const file = new Folder({
 			source: 'https://cloud.domain.com/remote.php/dav/files/emma/Photos/',
-			owner: 'emma'
+			owner: 'emma',
 		})
 		expect(file.source).toBe('https://cloud.domain.com/remote.php/dav/files/emma/Photos')
 	})
 
 	test('Invalid rename', () => {
 		const file = new Folder({
 			source: 'https://cloud.domain.com/remote.php/dav/files/emma/Photos/',
-			owner: 'emma'
+			owner: 'emma',
 		})
 		expect(() => file.rename('new/folder')).toThrowError('Invalid basename')
 	})
@@ -35,19 +35,29 @@ describe('FileId attribute', () => {
 		const file = new File({
 			source: 'https://cloud.domain.com/remote.php/dav/picture.jpg',
 			mime: 'image/jpeg',
-			owner: 'emma'
+			owner: 'emma',
 		})
 		expect(file.fileid).toBeUndefined()
 	})
 
-	test('FileId source ending slash', () => {
+	test('FileId null fallback', () => {
+		const file = new File({
+			source: 'https://cloud.domain.com/remote.php/dav/picture.jpg',
+			mime: 'image/jpeg',
+			owner: 'emma',
+			id: 1234,
+		})
+		expect(file.fileid).toBe(1234)
+	})
+
+	test('FileId attributes fallback', () => {
 		const file = new Folder({
 			source: 'https://cloud.domain.com/remote.php/dav/files/emma/Photos/',
 			mime: 'image/jpeg',
 			owner: 'emma',
 			attributes: {
-				fileid: 1234
-			}
+				fileid: 1234,
+			},
 		})
 		expect(file.fileid).toBe(1234)
 	})

lib/files/node.ts

@@ -203,10 +203,11 @@ export abstract class Node {
 	}
 
 	/**
-	 * Get the file id if defined in attributes
+	 * Get the node id if defined.
+	 * Will look for the fileid in attributes if undefined.
 	 */
 	get fileid(): number|undefined {
-		return this.attributes?.fileid
+		return this._data?.id || this.attributes?.fileid
 	}
 
 	/**