fix: allow updating session in SessionProvider when logged out #11958
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
Currently when after doing a
signOut()
request there is no way to update the session on the client side. If the session on the server isnull
setSession
is never called. So the only way to make sure the client has an up to date value in theSessionProvider
is to do a hard refresh.Current:
After this PR:
Potential problem that may arise is that
fetchData
on line 495 returnsnull
when an the fetch errors. So In that case the SessionProvider will also be updated withnull
and the client will assume it's logged out.🧢 Checklist
🎫 Affected issues
This issue is related, where it was not possible to update the session after loggin in: #11075
📌 Resources