-
Notifications
You must be signed in to change notification settings - Fork 360
[step4] 로또 (수동) #1123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SaraHan774
wants to merge
14
commits into
next-step:sarahan774
Choose a base branch
from
SaraHan774:step4
base: sarahan774
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[step4] 로또 (수동) #1123
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b8b79b2
[step4] 기능요구사항 작성
SaraHan774 23bbbeb
[step4] 패키지 이동
SaraHan774 a1811f4
[step4] 패키지 이동
SaraHan774 5ba14a7
[step4] 패키지 이동
SaraHan774 cdf5c97
[step4] 사용자가 수동으로 추첨 번호를 입력할 수 있도록 함
SaraHan774 ae35355
[step4] LottoFactoryTest 피드백 반영
SaraHan774 7888698
[step4] model 패키지 제거 - 테스트
SaraHan774 7495f95
[step4] Rank 예외 던지는 부분 제거, nullable 반환 타입으로 수정
SaraHan774 8b7c15c
[step4] 테스트 코드 보강 및 수정
SaraHan774 fee8905
[step4] InputView 내부에서 프롬프트 메시지 보여주도록 수정
SaraHan774 8f13536
[step4] 변수명 수정, 함수 중괄호 추가
SaraHan774 68a0cb7
[step4] LottoFactory 예외처리 추가
SaraHan774 bfe4bc6
[step4] LottoTest 추가
SaraHan774 bbeff53
[step4] 숫자 형식이 아닐경우 예외 던짐
SaraHan774 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
src/main/kotlin/lotto/domain/model/Lotto.kt → src/main/kotlin/lotto/domain/Lotto.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
package lotto.domain.model | ||
package lotto.domain | ||
|
||
@JvmInline | ||
value class Lotto(val value: List<LottoNumber>) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 지금보니까 LottoTest가 없네요!! 테스트를 작성해보면 어떨까요? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 그러네요 이상하게 커버리지에는 초록색으로 뜨던 ..;?! |
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
.../kotlin/lotto/domain/model/LottoNumber.kt → src/main/kotlin/lotto/domain/LottoNumber.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
package lotto.domain.model | ||
package lotto.domain | ||
|
||
@JvmInline | ||
value class LottoNumber(val value: Int) { | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...lin/lotto/domain/model/LottoNumberTest.kt → ...st/kotlin/lotto/domain/LottoNumberTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
당첨번호라는 의미를 가진 변수인데, myLotto가 괜찮을기 고민 해보면 좋을 것 같아요 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
좋습니다!