Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/nanocld/cleaner metric services with file separation #1104

Merged

Conversation

leon3s
Copy link
Member

@leon3s leon3s commented Oct 24, 2024

No description provided.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 82.97872% with 8 lines in your changes missing coverage. Please review.

Project coverage is 61.84%. Comparing base (66be35e) to head (a287a65).
Report is 2 commits behind head on nightly.

Files with missing lines Patch % Lines
bin/nanocld/src/services/metric/count.rs 11.11% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           nightly    #1104      +/-   ##
===========================================
- Coverage    61.91%   61.84%   -0.07%     
===========================================
  Files          227      231       +4     
  Lines        15757    15757              
===========================================
- Hits          9756     9745      -11     
- Misses        6001     6012      +11     
Flag Coverage Δ
unittests 61.84% <82.97%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leon3s leon3s merged commit 85365ba into nightly Oct 24, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant