feat(query_perf_monitoring): Implement query performance monitoring metrics #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…king sessions and wait events (#7) * feat: Introducing query performance monitoring for slow queries, blocking sessions and wait events. * refactor: Implemented a limit for wait events, blocking sessions, and included bug fixes (#8) * refactor: Implemented a limit for wait events, blocking sessions, and included bug fixes. * Included a stepID for each row during the query execution iteration * Added fix for stepID * Added a fix to ensure that increments correctly. * Renamed FETCH_INTERVAL to SLOW_QUERY_FETCH_INTERVAL * Added detailed logging for each operation, including the time taken for execution. * refactor: Added configuration option to disable query performance metrics per database (#10) * refactor: Added configuration option to disable query performance metrics per database * Revised the list of input arguments for retrieving individual queries. * Updated logging messages and Revised the list of input arguments for retrieving wait events and blocking session queries. * Added a helper function to obtain a list of unique databases to exclude. * code refactoring * Added fix for number of arguments mismatch for the SQL query * removed rebind functionality * updated metricset limit * reverted metricset limit * minor code refactoring * fixed linting errors * fixed linting errors * refactor: resolving linting errors (#12) * refactor: resolving linting errors * fixing linting errors * fixing linting errors * fixing linting errors * fixing linting errors * fixing linting errors * refactor: resolving linting errors (#13) * refactor: changed log.info to log.debug and other bug fixes (#14) * refactor: code refactoring and addressing review comments (#15) * refactor: code refactoring and addressing review comments * lint issue fixes * lint issue fixes * lint issue fixes * lint issue fixes * lint issue fixes * refactor: Added a limit on individual query details and defined min/max values for the limit threshold. (#16) * refactor: Added a limit on individual query details and defined min/max values for the limit threshold. * minor enhancements * minor enhancements * minor enhancements * refactor: code resturcturing (#17) * refactor: code resturcturing * file name changes * Blocking sessions query update * Blocking sessions query update * package changes * Added code review fixes * Added code review fixes * Added code review fixes * Added code review fixes * Added code review fixes * Added code review fixes * Added code review fixes * query execution plan changes * file name changes * Added code review fixes
…Delete and Update queries. Updated blocking sessions data model (#18)
…ion times (#20) Updated wait events query to analyze wait events and execution times
…files (#19) Added unit testcases
* updated mysql version check fuction, args list, testcases, checkEssentialInstruments function. * Improved comments for configuration constants for clarity and context. * Rename EnableQueryPerformance to EnableQueryMonitoring in ArgumentList struct
…tegration process. This change ensures that the existing integration continues to function smoothly without interruption.
…erences between the OpenDB function here and the one in mysql.go, specifically noting their use of different drivers.
test: add integration tests for performance monitoring
* refactor: Added utility to escape backticks in JSON strings * Added unit tests for ValidateAndSetDefaults function and fix argument handling
rajrohanyadav
approved these changes
Jan 27, 2025
sairaj18
merged commit 1174151
into
newrelic:pre-release_query_performance_monitoring
15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating this PR to unblock tara-team form creating pre-releases of the integration with the changes of query performance monitoring.
Going forward the pre-release_query_performance branch in the nri-mysql main repo will be used to create new pre-releases until we merge PRs related to forked repo epic to main repo epic