feat: Enhanced query performance monitoring features to track slow queries, examine query execution plans, monitor wait events, and identify blocking sessions. #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
spathlavath
changed the title
rahulreddy15
requested changes
Jan 9, 2025
src/query-performance-monitoring/performance-metrics-collectors/query_execution_plan.go
Show resolved
Hide resolved
sairaj18
reviewed
Jan 9, 2025
spathlavath
commented
Jan 9, 2025
There was a problem hiding this comment.
@rahulreddy15
thanks for reviewing
please share comments with criticality
so we can work on them as per priority
src/query-performance-monitoring/performance-metrics-collectors/query_execution_plan.go
Show resolved
Hide resolved
sairaj18
reviewed
Jan 15, 2025
spathlavath
force-pushed
the
epic_performance_monitoring
branch
5 times, most recently
from
6ff4f65 to
ec80544
Compare
…king sessions and wait events (#7) * feat: Introducing query performance monitoring for slow queries, blocking sessions and wait events. * refactor: Implemented a limit for wait events, blocking sessions, and included bug fixes (#8) * refactor: Implemented a limit for wait events, blocking sessions, and included bug fixes. * Included a stepID for each row during the query execution iteration * Added fix for stepID * Added a fix to ensure that increments correctly. * Renamed FETCH_INTERVAL to SLOW_QUERY_FETCH_INTERVAL * Added detailed logging for each operation, including the time taken for execution. * refactor: Added configuration option to disable query performance metrics per database (#10) * refactor: Added configuration option to disable query performance metrics per database * Revised the list of input arguments for retrieving individual queries. * Updated logging messages and Revised the list of input arguments for retrieving wait events and blocking session queries. * Added a helper function to obtain a list of unique databases to exclude. * code refactoring * Added fix for number of arguments mismatch for the SQL query * removed rebind functionality * updated metricset limit * reverted metricset limit * minor code refactoring * fixed linting errors * fixed linting errors * refactor: resolving linting errors (#12) * refactor: resolving linting errors * fixing linting errors * fixing linting errors * fixing linting errors * fixing linting errors * fixing linting errors * refactor: resolving linting errors (#13) * refactor: changed log.info to log.debug and other bug fixes (#14) * refactor: code refactoring and addressing review comments (#15) * refactor: code refactoring and addressing review comments * lint issue fixes * lint issue fixes * lint issue fixes * lint issue fixes * lint issue fixes * refactor: Added a limit on individual query details and defined min/max values for the limit threshold. (#16) * refactor: Added a limit on individual query details and defined min/max values for the limit threshold. * minor enhancements * minor enhancements * minor enhancements * refactor: code resturcturing (#17) * refactor: code resturcturing * file name changes * Blocking sessions query update * Blocking sessions query update * package changes * Added code review fixes * Added code review fixes * Added code review fixes * Added code review fixes * Added code review fixes * Added code review fixes * Added code review fixes * query execution plan changes * file name changes * Added code review fixes
…Delete and Update queries. Updated blocking sessions data model (#18)
…ion times (#20) Updated wait events query to analyze wait events and execution times
spathlavath
force-pushed
the
epic_performance_monitoring
branch
from
ec80544 to
c796359
Compare
sigilioso
reviewed
Jan 15, 2025
sigilioso
reviewed
Jan 15, 2025
sigilioso
reviewed
Jan 15, 2025
sigilioso
reviewed
Jan 15, 2025
sigilioso
reviewed
Jan 15, 2025
sigilioso
reviewed
Jan 15, 2025
sigilioso
reviewed
Jan 15, 2025
sigilioso
reviewed
Jan 15, 2025
test: add integration tests for performance monitoring
sairaj18
reviewed
Jan 21, 2025
sairaj18
reviewed
Jan 21, 2025
sairaj18
reviewed
Jan 21, 2025
src/query-performance-monitoring/performance-metrics-collectors/query_details_test.go
Outdated
Show resolved
Hide resolved
sairaj18
reviewed
Jan 21, 2025
src/query-performance-monitoring/performance-metrics-collectors/query_details_test.go
Outdated
Show resolved
Hide resolved
* refactor: Added utility to escape backticks in JSON strings * Added unit tests for ValidateAndSetDefaults function and fix argument handling
sigilioso
reviewed
Jan 22, 2025
src/query-performance-monitoring/performance-metrics-collectors/query_details.go
Outdated
Show resolved
Hide resolved
sairaj18
reviewed
Jan 24, 2025
sairaj18
reviewed
Jan 24, 2025
sairaj18
reviewed
Jan 24, 2025
sairaj18
reviewed
Jan 24, 2025
sairaj18
reviewed
Jan 24, 2025
sairaj18
reviewed
Jan 24, 2025
sairaj18
reviewed
Jan 24, 2025
sairaj18
reviewed
Jan 24, 2025
sairaj18
reviewed
Jan 24, 2025
sairaj18
reviewed
Jan 24, 2025
sairaj18
reviewed
Jan 27, 2025
sairaj18
reviewed
Jan 27, 2025
tests/integration/json-schema-files-5.7.35/mysql-schema-inventory-master.json
Show resolved
Hide resolved
sigilioso
reviewed
Jan 27, 2025
src/query-performance-monitoring/performance-metrics-collectors/blocking_sessions_test.go
Show resolved
Hide resolved
src/query-performance-monitoring/performance-metrics-collectors/blocking_sessions_test.go
Show resolved
Hide resolved
src/query-performance-monitoring/performance-metrics-collectors/blocking_sessions_test.go
Show resolved
Hide resolved
src/query-performance-monitoring/performance-metrics-collectors/blocking_sessions_test.go
Show resolved
Hide resolved
src/query-performance-monitoring/performance-metrics-collectors/blocking_sessions_test.go
Show resolved
Hide resolved
src/query-performance-monitoring/performance-metrics-collectors/query_execution_plan.go
Show resolved
Hide resolved
src/query-performance-monitoring/performance-metrics-collectors/query_execution_plan.go
Show resolved
Hide resolved
src/query-performance-monitoring/performance-metrics-collectors/query_execution_plan.go
Show resolved
Hide resolved
src/query-performance-monitoring/performance-metrics-collectors/query_execution_plan.go
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced query performance monitoring features to track slow queries, examine query execution plans, monitor wait events, and identify blocking sessions.
Co-authored-by:
Srikanth @RamanaReddy8801