-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LLM Custom Attributes Context Manager API #1214
Conversation
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1214 +/- ##
==========================================
+ Coverage 81.20% 81.24% +0.03%
==========================================
Files 197 198 +1
Lines 21644 21675 +31
Branches 3428 3434 +6
==========================================
+ Hits 17576 17609 +33
+ Misses 2937 2935 -2
Partials 1131 1131 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to let you fix the implementation issues first and then I'll take a look at the tests. It looks like there's just some small but large impact issues with the implementation and I think once we fix those the tests will probably be in better shape too.
…ython-agent into llm-custom-attrs-api
…ython-agent into llm-custom-attrs-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should just use our regular approach of attaching the attrs to the transaction without using contextvars. I don't see that it's needed in this case and I think simpler is better here. Other than that, I just had one minor suggestion for one of the tests. I also committed a small change to undo some unnecessary formatting changes.
…ython-agent into llm-custom-attrs-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple small suggestions about the tests-otherwise looks good!
Add new WithLlmCustomAttributes context manager API