Release 11.4 #987
Merged
Release 11.4 #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Add an option to control which PHP version is to be used in devenv service via PHP env var passed at the time when dev-shell is started (or any dev-* target is build). 2. Simplify `composer` and `go` install. 3. Fix `devenv` service image build for PHPs 7.2 and 7.3. 4. Apply `Dockerfile` best practices
This PR does the following: - Modifies how the action name is retrieved, so that it is compatible with CakePHP 4.x and 5.x - Adds correct detection file for CakePHP 4.x and 5.x - Adds call to `nr_txn_suggest_package_supportability_metric` in `nr_cakephp_enable` --------- Co-authored-by: Michal Nowacki <[email protected]>
Security scan with trivy will be run on push to main and dev, pull request, and weekly. trivy will skip scanning vendor subdirectory because the agent is not using code from that directory.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #987 +/- ##
==========================================
+ Coverage 78.54% 78.68% +0.14%
==========================================
Files 196 196
Lines 27103 27047 -56
==========================================
- Hits 21287 21281 -6
+ Misses 5816 5766 -50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mfulb
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.