Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: address trivy scan issues #986

Merged
merged 2 commits into from
Dec 5, 2024

Conversation

lavarou
Copy link
Member

@lavarou lavarou commented Nov 15, 2024

No description provided.

@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Nov 15, 2024

Test Suite Status Result
Multiverse 6/7 passing
SOAK 0/62 passing

@lavarou lavarou changed the title Chore/address trivy scan issues chore: address trivy scan issues Nov 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.68%. Comparing base (9ec7415) to head (7bc36cc).
Report is 1 commits behind head on ci/add-security-scan.

Additional details and impacted files
@@                  Coverage Diff                  @@
##           ci/add-security-scan     #986   +/-   ##
=====================================================
  Coverage                 78.68%   78.68%           
=====================================================
  Files                       196      196           
  Lines                     27047    27047           
=====================================================
  Hits                      21281    21281           
  Misses                     5766     5766           
Flag Coverage Δ
agent-for-php-7.2 78.69% <ø> (ø)
agent-for-php-7.3 78.71% <ø> (ø)
agent-for-php-7.4 78.41% <ø> (ø)
agent-for-php-8.0 78.43% <ø> (ø)
agent-for-php-8.1 78.42% <ø> (ø)
agent-for-php-8.2 78.01% <ø> (ø)
agent-for-php-8.3 78.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lavarou lavarou force-pushed the ci/add-security-scan branch from cab9c27 to eccaf64 Compare November 20, 2024 14:39
@lavarou lavarou force-pushed the chore/address-trivy-scan-issues branch from 94ee72c to f6097af Compare November 20, 2024 18:09
@lavarou lavarou force-pushed the ci/add-security-scan branch from eccaf64 to 9ec7415 Compare December 5, 2024 15:08
Use a non-root, anonymous developer user as a default user in devenv service
container.

See https://docs.docker.com/build/building/best-practices/#user
Remove dead code, which causes flaggs being risen by trivy scan.
@lavarou lavarou force-pushed the chore/address-trivy-scan-issues branch from f6097af to 7bc36cc Compare December 5, 2024 15:09
@lavarou lavarou merged commit ed68ea5 into ci/add-security-scan Dec 5, 2024
31 checks passed
@lavarou lavarou deleted the chore/address-trivy-scan-issues branch December 5, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants