-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(agent): expose trace id and span id with app metadata #933
base: refactor/security-agent-support
Are you sure you want to change the base?
refactor(agent): expose trace id and span id with app metadata #933
Conversation
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor/security-agent-support #933 +/- ##
===================================================================
- Coverage 78.67% 78.63% -0.04%
===================================================================
Files 194 194
Lines 27285 27297 +12
===================================================================
Hits 21466 21466
- Misses 5819 5831 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
is_allocated = true; | ||
break; | ||
case NR_PHP_CSEC_METADATA_SPAN_ID: | ||
id_value = nr_txn_get_current_span_id(NRPRG(txn)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The span id will be different depending on which agent's instrumentation is called first with OAPI
Along with other app metadata, expose trace id and span id as well