Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(agent): expose trace id and span id with app metadata #933

Open
wants to merge 3 commits into
base: refactor/security-agent-support
Choose a base branch
from

Conversation

anmol-ap
Copy link

@anmol-ap anmol-ap commented Jul 2, 2024

Along with other app metadata, expose trace id and span id as well

@anmol-ap anmol-ap requested a review from ZNeumann July 2, 2024 06:23
@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Jul 2, 2024

Test Suite Status Result
Multiverse 0/7 passing
SOAK 54/62 passing

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 78.63%. Comparing base (1a4bc74) to head (fc58607).

Files Patch % Lines
agent/csec_metadata.c 0.00% 15 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                         @@
##           refactor/security-agent-support     #933      +/-   ##
===================================================================
- Coverage                            78.67%   78.63%   -0.04%     
===================================================================
  Files                                  194      194              
  Lines                                27285    27297      +12     
===================================================================
  Hits                                 21466    21466              
- Misses                                5819     5831      +12     
Flag Coverage Δ
agent-for-php-7.0 77.40% <0.00%> (-0.03%) ⬇️
agent-for-php-7.1 77.11% <0.00%> (-0.04%) ⬇️
agent-for-php-7.2 78.04% <0.00%> (-0.04%) ⬇️
agent-for-php-7.3 78.06% <0.00%> (-0.04%) ⬇️
agent-for-php-7.4 77.76% <0.00%> (-0.04%) ⬇️
agent-for-php-8.0 77.83% <0.00%> (-0.04%) ⬇️
agent-for-php-8.1 77.81% <0.00%> (-0.04%) ⬇️
agent-for-php-8.2 77.41% <0.00%> (-0.04%) ⬇️
agent-for-php-8.3 77.41% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

is_allocated = true;
break;
case NR_PHP_CSEC_METADATA_SPAN_ID:
id_value = nr_txn_get_current_span_id(NRPRG(txn));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The span id will be different depending on which agent's instrumentation is called first with OAPI

@bduranleau-nr bduranleau-nr added the on hold This issue or pull request is necessary, but better suited for the future label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csec-agent on hold This issue or pull request is necessary, but better suited for the future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants