Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(agent): expose app metadata for csec via global symbol #922

Open
wants to merge 12 commits into
base: security-agent-support
Choose a base branch
from

Conversation

lavarou
Copy link
Member

@lavarou lavarou commented Jun 21, 2024

Rather than providing a PHP user function to expose app metadata to PHP userland, export a global symbol for cseg agent to use.

@lavarou lavarou requested review from ZNeumann and anmol-ap June 21, 2024 16:29
@newrelic-php-agent-bot
Copy link

newrelic-php-agent-bot commented Jun 21, 2024

Test Suite Status Result
Multiverse 0/7 passing
SOAK 54/56 passing

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 44 lines in your changes missing coverage. Please review.

Project coverage is 78.67%. Comparing base (c2f0349) to head (fb054ab).

Files Patch % Lines
agent/csec_metadata.c 0.00% 44 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           security-agent-support     #922      +/-   ##
==========================================================
+ Coverage                   78.52%   78.67%   +0.15%     
==========================================================
  Files                         194      194              
  Lines                       27339    27285      -54     
==========================================================
- Hits                        21467    21466       -1     
+ Misses                       5872     5819      -53     
Flag Coverage Δ
agent-for-php-7.0 77.43% <0.00%> (-0.01%) ⬇️
agent-for-php-7.1 77.15% <0.00%> (-0.04%) ⬇️
agent-for-php-7.2 78.07% <0.00%> (-0.04%) ⬇️
agent-for-php-7.3 78.09% <0.00%> (-0.04%) ⬇️
agent-for-php-7.4 77.80% <0.00%> (-0.04%) ⬇️
agent-for-php-8.0 77.86% <0.00%> (+<0.01%) ⬆️
agent-for-php-8.1 77.85% <0.00%> (+<0.01%) ⬆️
agent-for-php-8.2 77.45% <0.00%> (+<0.01%) ⬆️
agent-for-php-8.3 77.45% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lavarou lavarou marked this pull request as draft June 24, 2024 14:47
@lavarou lavarou marked this pull request as ready for review June 26, 2024 21:22
lavarou added 4 commits June 26, 2024 17:24
Rather than providing a PHP user function to expose app metadata to PHP
userland, export a global symbol for cseg agent to use.
Replace 'transport' struct, which would have to be versioned, with a simple
getter API of `get(key, &ptr)` signature.
This approach adds some level of protection (compiler type checking) from
misusing the API.
@lavarou lavarou force-pushed the refactor/security-agent-support branch from c912dc9 to 1a4bc74 Compare June 26, 2024 21:24
@lavarou lavarou requested review from anmol-ap and ZNeumann June 26, 2024 21:25
@anmol-ap anmol-ap self-requested a review June 27, 2024 09:46
@bduranleau-nr bduranleau-nr added the on hold This issue or pull request is necessary, but better suited for the future label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csec-agent on hold This issue or pull request is necessary, but better suited for the future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants