-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(agent): expose app metadata for csec via global symbol #922
Open
lavarou
wants to merge
12
commits into
security-agent-support
Choose a base branch
from
refactor/security-agent-support
base: security-agent-support
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## security-agent-support #922 +/- ##
==========================================================
+ Coverage 78.52% 78.67% +0.15%
==========================================================
Files 194 194
Lines 27339 27285 -54
==========================================================
- Hits 21467 21466 -1
+ Misses 5872 5819 -53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
anmol-ap
approved these changes
Jun 24, 2024
ZNeumann
approved these changes
Jun 24, 2024
Rather than providing a PHP user function to expose app metadata to PHP userland, export a global symbol for cseg agent to use.
Replace 'transport' struct, which would have to be versioned, with a simple getter API of `get(key, &ptr)` signature.
This approach adds some level of protection (compiler type checking) from misusing the API.
lavarou
force-pushed
the
refactor/security-agent-support
branch
from
June 26, 2024 21:24
c912dc9
to
1a4bc74
Compare
anmol-ap
approved these changes
Jun 27, 2024
anmol-ap
approved these changes
Jun 27, 2024
bduranleau-nr
added
the
on hold
This issue or pull request is necessary, but better suited for the future
label
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than providing a PHP user function to expose app metadata to PHP userland, export a global symbol for cseg agent to use.