feat(agent): Implements log decorating #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 10.12
Adds linking metadata to the Monolog LogRecord by using the 'extra' array element to store a string containing the log decorating linking metadata.
lavarou
changed the title
Codecov Report
@@ Coverage Diff @@
## dev #733 +/- ##
=======================================
Coverage 78.21% 78.22%
=======================================
Files 188 188
Lines 25994 26030 +36
=======================================
+ Hits 20332 20362 +30
- Misses 5662 5668 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
These tests are not actually for PHP 5 only but are simply run with CLM disabled so a #skipif is not required.
The decorating processor function was being created multiple times if more than one handler was pushed. This was due to the scoped name of the function (in lowercase) was not being used in the search to see if it had been previously created. A new integration test was added to check the use case where more than one handler is being used. The handler is now checked to see if it supported the pushProcessor() functionality and if it does not then a warning is generated to notify the user messages sent to that handler will not be decorated.
mfulb
requested review from
lavarou,
bduranleau-nr,
ZNeumann,
zsistla and
hahuja2
|
Hi, just a curious user here.. we've been eagerly awaiting PHP agent support for logging 'extra' (aka context) data along with each log entry (similar to how the java agent does it). Does this PR accomplish that? |
lavarou
reviewed
Sep 26, 2023
lavarou
reviewed
Sep 26, 2023
lavarou
reviewed
Sep 26, 2023
tests/integration/logging/monolog3/test_monolog_decoration_basic.php
Outdated
Show resolved
Hide resolved
lavarou
reviewed
Sep 26, 2023
tests/integration/logging/monolog3/test_monolog_decoration_basic.php
Outdated
Show resolved
Hide resolved
lavarou
approved these changes
Sep 26, 2023
tests/integration/logging/monolog3/test_monolog_decoration_multiple_handlers.php
Show resolved
Hide resolved
tests/integration/logging/monolog2/test_monolog_decoration_multiple_handlers.php
Show resolved
Hide resolved
|
Are there any tests (unit or integration) to verify that |
hahuja2
approved these changes
Sep 26, 2023
lavarou
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds linking metadata to the Monolog LogRecord by using the 'extra' array element to store a string containing the log decorating linking metadata.