fix: Refactored wrapper to load and wrap handler early #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mrickard <[email protected]>
Signed-off-by: mrickard <[email protected]>
…per is loaded Signed-off-by: mrickard <[email protected]>
…ore the wrapper is loaded Signed-off-by: mrickard <[email protected]>
…d as esm Signed-off-by: mrickard <[email protected]>
Signed-off-by: mrickard <[email protected]>
Signed-off-by: mrickard <[email protected]>
Signed-off-by: mrickard <[email protected]>
Signed-off-by: mrickard <[email protected]>
…sync code paths Signed-off-by: mrickard <[email protected]>
…g wrapping before applying args Signed-off-by: mrickard <[email protected]>
Signed-off-by: mrickard <[email protected]>
…ndler definition in a function to be called in tests. Signed-off-by: mrickard <[email protected]>
…state unit test files. Restructured ESM unit tests to inspect errors from failures in the wrapping/import phase Signed-off-by: mrickard <[email protected]>
jsumners-nr
reviewed
Nov 27, 2023
Signed-off-by: mrickard <[email protected]>
jsumners-nr
approved these changes
Nov 28, 2023
bizob2828
approved these changes
Nov 28, 2023
|
|
||
| t.test('should wrap handler in transaction', async(t) => { |
There was a problem hiding this comment.
do we need a unit test for lambda in cjs with callback or are we just relying on the integration tests for this?
There was a problem hiding this comment.
We're relying on integration tests with the functions that return callbacks. For those, the issue hasn't been loss of instrumentation, but an interruption in the return value, so we test that explicitly for the callback-returning functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Node wrapper file and updates tests. A previous PR introduced support for no-code-change instrumentation of ESM functions, but handled CJS functions asynchronously, which was not compatible with callback-returning Lambda functions. A later PR resolved that issue, but deferred wrapping the user's Lambda handler until invocation time. This PR wraps handlers on load rather than on invocation, and preserves a synchronous path for CJS functions along with an asynchronous path for ESM functions.