Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature work: Disable AspNetCore middleware wrapper #2740

Merged

Conversation

tippmar-nr
Copy link
Member

Disables the AspNetCore middleware wrapper (NewRelic.Providers.Wrapper.AspNetCore6Plus.WrapPipelineMiddleware) when running in Azure function mode, to prevent duplicate transactions from being created.

Updates integration tests to add checking of transaction sample attributes.

@tippmar-nr tippmar-nr requested a review from a team as a code owner September 6, 2024 19:37
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.16%. Comparing base (e41c19e) to head (162b025).

Additional details and impacted files
@@                     Coverage Diff                     @@
##           feature/azure-functions    #2740      +/-   ##
===========================================================
- Coverage                    81.17%   81.16%   -0.02%     
===========================================================
  Files                          459      459              
  Lines                        29204    29204              
  Branches                      3223     3223              
===========================================================
- Hits                         23707    23703       -4     
- Misses                        4708     4711       +3     
- Partials                       789      790       +1     
Flag Coverage Δ
Agent 82.19% <ø> (-0.02%) ⬇️
Profiler 71.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@tippmar-nr tippmar-nr merged commit 5464347 into feature/azure-functions Sep 9, 2024
92 of 94 checks passed
@tippmar-nr tippmar-nr deleted the feature-work/disable-aspnetcore-wrapper branch September 9, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants