Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature work: Azure functions integration test framework #2737

Conversation

tippmar-nr
Copy link
Member

  • Adds a testing framework and a very basic implementation of an Azure function test app and corresponding integration tests.
  • Updates the all_solutions workflow to install required tools and include the AzureFunction workspace in the integration test matrix.
  • Updates the profiler to exclude FUNC.EXE (the local Azure test tool) from instrumentation. Note that I had to update a number of profiler unit tests also, since I'm now referencing _systemCalls in areas that tests previously didn't expect.

@tippmar-nr tippmar-nr requested a review from a team as a code owner September 4, 2024 21:11
Copy link
Member

@chynesNR chynesNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 58.82353% with 7 lines in your changes missing coverage. Please review.

Project coverage is 81.13%. Comparing base (9483c5d) to head (5302237).

Files with missing lines Patch % Lines
...nt/NewRelic/Profiler/MethodRewriter/ISystemCalls.h 0.00% 4 Missing ⚠️
...nt/NewRelic/Profiler/Configuration/Configuration.h 76.92% 3 Missing ⚠️
Additional details and impacted files
@@                     Coverage Diff                     @@
##           feature/azure-functions    #2737      +/-   ##
===========================================================
- Coverage                    81.18%   81.13%   -0.05%     
===========================================================
  Files                          459      459              
  Lines                        29196    29204       +8     
  Branches                      3223     3223              
===========================================================
- Hits                         23703    23695       -8     
- Misses                        4703     4716      +13     
- Partials                       790      793       +3     
Flag Coverage Δ
Agent 82.16% <ø> (-0.04%) ⬇️
Profiler 71.98% <58.82%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Agent/NewRelic/Profiler/Logging/Logger.h 86.95% <ø> (ø)
...nt/NewRelic/Profiler/Configuration/Configuration.h 75.55% <76.92%> (-1.22%) ⬇️
...nt/NewRelic/Profiler/MethodRewriter/ISystemCalls.h 46.55% <0.00%> (-2.54%) ⬇️

... and 1 file with indirect coverage changes

@tippmar-nr tippmar-nr merged commit 37d155e into feature/azure-functions Sep 5, 2024
92 of 94 checks passed
@tippmar-nr tippmar-nr deleted the feature-work/azure-function-integration-testing branch September 5, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants