feat: Oracle instrumentation update to support latest version #2721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… initial Console MFA tests for Oracle
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2721 +/- ##
=======================================
Coverage 80.91% 80.92%
=======================================
Files 458 458
Lines 29147 29147
Branches 3209 3209
=======================================
+ Hits 23585 23587 +2
+ Misses 4771 4770 -1
+ Partials 791 790 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Nice work! I think we need to add Oracle back to the integration tests workflow, right? |
No, that was done earlier this week via #2715 |
chynesNR
approved these changes
Aug 29, 2024
nrcventura
approved these changes
Aug 29, 2024
nr-ahemsath
reviewed
Aug 29, 2024
tests/Agent/IntegrationTests/UnboundedIntegrationTests/Oracle/OracleStoredProcedureTests.cs
Show resolved
Hide resolved
tests/Agent/IntegrationTests/UnboundedIntegrationTests/Oracle/OracleStoredProcedureTests.cs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, the .NET agent now instruments the latest
Oracle.ManagedDataAccessandOracle.ManagedDataAccess.Corelibraries.Oracle unbounded integration tests were migrated to use the ConsoleMultiFunctionApplication pattern and updated to exercise a range of library versions for both .NET Framework and .NET 6+. Note that the existing
EnterpriseLibraryOracleTestswere not migrated.