-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SQS: Distributed Tracing support #2591
Merged
tippmar-nr
merged 8 commits into
feature/sqs-instrumentation
from
feature-work/sqs-distributed-tracing
Jul 2, 2024
Merged
SQS: Distributed Tracing support #2591
tippmar-nr
merged 8 commits into
feature/sqs-instrumentation
from
feature-work/sqs-distributed-tracing
Jul 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g due to type conflict issues
… DT headers still has issues.
tippmar-nr
requested review from
a team,
jaffinito,
nrcventura,
nr-ahemsath,
chynesNR and
dotnet-agent-team-bot
July 2, 2024 19:11
chynesNR
reviewed
Jul 2, 2024
src/Agent/NewRelic/Agent/Extensions/NewRelic.Agent.Extensions/AwsSdk/SqsHelper.cs
Show resolved
Hide resolved
chynesNR
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
nrcventura
reviewed
Jul 2, 2024
src/Agent/NewRelic/Agent/Extensions/Providers/Wrapper/AwsSdk/AwsSdkPipelineWrapper.cs
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/sqs-instrumentation #2591 +/- ##
===============================================================
+ Coverage 80.75% 80.85% +0.10%
===============================================================
Files 459 459
Lines 29021 29048 +27
Branches 3188 3188
===============================================================
+ Hits 23435 23488 +53
+ Misses 4795 4772 -23
+ Partials 791 788 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
tippmar-nr
merged commit Jul 2, 2024
4a6c869
into
feature/sqs-instrumentation
89 of 90 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds distributed tracing support to SQS instrumentation.
Tests to follow in a separate PR after this one completes.