Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQS: Distributed Tracing support #2591

Merged

Conversation

tippmar-nr
Copy link
Member

Adds distributed tracing support to SQS instrumentation.

Tests to follow in a separate PR after this one completes.

Copy link
Member

@chynesNR chynesNR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 91.89189% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.85%. Comparing base (c4736c7) to head (b317edb).

Additional details and impacted files
@@                       Coverage Diff                       @@
##           feature/sqs-instrumentation    #2591      +/-   ##
===============================================================
+ Coverage                        80.75%   80.85%   +0.10%     
===============================================================
  Files                              459      459              
  Lines                            29021    29048      +27     
  Branches                          3188     3188              
===============================================================
+ Hits                             23435    23488      +53     
+ Misses                            4795     4772      -23     
+ Partials                           791      788       -3     
Flag Coverage Δ
Agent 81.77% <91.89%> (+0.11%) ⬆️
Profiler 72.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ions/NewRelic.Agent.Extensions/AwsSdk/SqsHelper.cs 63.49% <91.89%> (+63.49%) ⬆️

... and 2 files with indirect coverage changes

@tippmar-nr tippmar-nr merged commit 4a6c869 into feature/sqs-instrumentation Jul 2, 2024
89 of 90 checks passed
@tippmar-nr tippmar-nr deleted the feature-work/sqs-distributed-tracing branch July 2, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants