fix: Eliminate intermittent deadlock on agent startup. (#2183) #2184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing the .NET Standard agent build in the same manner as the .NET Framework build target.
tippmar-nr
requested review from
a team,
jaffinito,
nrcventura,
nr-ahemsath,
chynesNR and
dotnet-agent-team-bot
nr-ahemsath
approved these changes
Jan 11, 2024
nrcventura
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting a pull request. Please review our contributing guidelines and code of conduct.
Description
This PR changes how the agent is initialized when running on the .NET Standard 2.0 build target so that it uses the same "deferred" initialization pattern that the .NET Framework build target currently uses. This will eliminate an intermittent deadlock that has been observed at agent startup which has the unfortunate side effect of freezing the customer application.
A new integration test was added that verifies the agent does not deadlock. This test was run against the agent from the current
mainbranch and failed; the same test was run against this PR branch and succeeded.Fixes #2183