-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Re-implement wrap-websocket into agent #1342
base: main
Are you sure you want to change the base?
Conversation
f5e39c5
to
68f9d1b
Compare
Asset Size Report
Merging this pull request will result in the following asset size changes:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1342 +/- ##
==========================================
+ Coverage 88.70% 88.82% +0.12%
==========================================
Files 170 170
Lines 7331 7349 +18
Branches 1488 1487 -1
==========================================
+ Hits 6503 6528 +25
+ Misses 716 713 -3
+ Partials 112 108 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
General reminder that this is a high-risk feature. Should be deployed on its own and undergo more scrutiny before deployment |
I will be pulling this in locally and testing some things when i wrap up my current dev work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a change from previous draft?
PR description can be made more succinct; use the overview section for details. Example, "Tests are included for ..." are not relevant for customers on the release note summary view. Also reminder to link the JIRA ticket in issues section. |
@cwli24 lets coordinate a time to mob-test this if you dont mind |
Re-implement wrap-websocket code using ES6 extends syntax into the agent. This will allow supportability metrics to be reportable from websocket API usage.
Overview
We're re-implementing the wrap-websocket code into the agent that was taken out in 1.265.1 patch to address deploy issues. The new implementation uses ES6 extends syntax to include static class constants and all the properties of the original WebSocket object. Tests are included that cover usage with the third-party libraries
robust-websocket
andreconnecting-websocket
.Related Issue(s)
https://new-relic.atlassian.net/browse/NR-311646
Testing
Make sure tests pass.