Adding fips compliant agents to Prerelease on demand workflow #1942
Conversation
| BUILD_MODE: | ||
| description: 'Enable Normal, FIPS or ALL' | ||
| required: false | ||
| default: '' # "ALL" "FIPS": |
There was a problem hiding this comment.
Nit: perhaps using NON-FIPS instad of ' ' as variant for the non fips case
build/ci.mk
Outdated
| -v $(CURDIR):/go/src/github.com/newrelic/infrastructure-agent \ | ||
| -w /go/src/github.com/newrelic/infrastructure-agent \ |
There was a problem hiding this comment.
is it needed to place the code here? sounds like the old gopath dance
| arch: | ||
| - amd64 | ||
| - arm64 | ||
| # - arm |
There was a problem hiding this comment.
is it a leftover? perhaps adding a comment
There was a problem hiding this comment.
same on the others build yamls def
There was a problem hiding this comment.
I've removed these leftover comments
| package main | ||
|
|
||
| import ( | ||
| "context" | ||
| "flag" | ||
| "fmt" | ||
| "github.com/newrelic/infrastructure-agent/pkg/ipc" |
There was a problem hiding this comment.
this change looks like a wrong ide config
|
|
||
| import ( | ||
| "context" | ||
| _ "crypto/tls/fipsonly" |
There was a problem hiding this comment.
is this the only diff between the two files? did you consider to extract as much as possible from this file into a separate file inside the same package ? or couldn't this dep be added in another file with just the dependency ? The objective would be to avoid code duplication.
There was a problem hiding this comment.
same comment would apply for the three binaries, i think the most important is the newrelic-infa.go
There was a problem hiding this comment.
I mean having an extra file fips_deps.go with
//go:build fips
package main
import (
_ "crypto/tls/fipsonly"
)Would that work?
There was a problem hiding this comment.
Thanks for the comment! I've updated the code and files to reflect this
https://new-relic.atlassian.net/browse/NR-268769