Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nri-bundle] Adding ebpf agent to nri bundle. #1520

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

Philip-R-Beckwith
Copy link
Contributor

@Philip-R-Beckwith Philip-R-Beckwith commented Nov 4, 2024

Is this a new chart

No.

What this PR does / why we need it:

Allows users to install the eBPF agent chart through the Nri bundle chart.

Which issue this PR fixes

(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

  • fixes # N/A

Special notes for your reviewer:

N/A

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [mychartname])

@Philip-R-Beckwith Philip-R-Beckwith requested a review from a team as a code owner November 4, 2024 22:32
@Philip-R-Beckwith Philip-R-Beckwith requested a review from a team as a code owner November 7, 2024 04:18
@Philip-R-Beckwith Philip-R-Beckwith changed the title Adding ebpf agent to bundle [nri-bundle] Adding ebpf agent to nri bundle. Nov 7, 2024
Signed-off-by: pbeckwith <[email protected]>
kpattaswamy
kpattaswamy previously approved these changes Nov 7, 2024
Copy link
Member

@kpattaswamy kpattaswamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will require a review outside of me but LGTM

@@ -26,6 +26,9 @@ dependencies:
- name: newrelic-pixie
repository: https://newrelic.github.io/helm-charts
version: 2.1.6
- name: nr-ebpf-agent
repository: https://newrelic.github.io/helm-charts
version: 0.1.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update it to 0.1.12?

@@ -65,6 +66,11 @@ dependencies:
condition: newrelic-pixie.enabled
version: 2.1.6

- name: nr-ebpf-agent
version: 0.1.10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.1.12?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants