Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protect trace observer from leaking license keys on error #846

Merged
merged 1 commit into from
Feb 15, 2024
Merged

protect trace observer from leaking license keys on error #846

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion v3/newrelic/trace_observer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
// Copyright 2020 New Relic Corporation. All rights reserved.
// SPDX-License-Identifier: Apache-2.0

//go:build go1.9
// +build go1.9

// This build tag is necessary because GRPC/ProtoBuf libraries only support Go version 1.9 and up.

package newrelic
Expand Down Expand Up @@ -184,10 +186,11 @@ func newDialOptions(cfg observerConfig) []grpc.DialOption {
func (to *gRPCtraceObserver) connectToTraceObserver() {
conn, err := grpc.Dial(to.endpoint.host, to.dialOptions...)
if nil != err {
errMsg := strings.Replace(err.Error(), to.license, "--REDACTED_LICENSE_KEY--", -1)
// this error is unrecoverable and will not be retried
to.log.Error("trace observer unable to dial grpc endpoint", map[string]interface{}{
"host": to.endpoint.host,
"err": err.Error(),
"err": errMsg,
})
return
}
Expand Down
Loading