Skip to content

Commit

Permalink
complete
Browse files Browse the repository at this point in the history
  • Loading branch information
nr-swilloughby committed Feb 15, 2025
1 parent 8221d98 commit fd9a62b
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 31 deletions.
5 changes: 0 additions & 5 deletions v3/newrelic/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -588,10 +588,6 @@ type ApplicationLogging struct {
// Toggles whether the agent enriches local logs printed to console so they can be sent to new relic for ingestion
Enabled bool
}
// CustomTags struct {
// Enabled bool
// Tags map[string]string
// }
// We want to enable this when your app collects fewer logs, or if your app can afford to compile the json
// during log collection, slowing down the execution of the line of code that will write the log. If your
// application collects logs at a high frequency or volume, or it can not afford the slowdown of marshaling objects
Expand Down Expand Up @@ -676,7 +672,6 @@ func defaultConfig() Config {
c.ApplicationLogging.Metrics.Enabled = true
c.ApplicationLogging.LocalDecorating.Enabled = false
c.ApplicationLogging.ZapLogger.AttributesFrontloaded = true
// c.ApplicationLogging.CustomTags.Enabled = false
c.BrowserMonitoring.Enabled = true
// browser monitoring attributes are disabled by default
c.BrowserMonitoring.Attributes.Enabled = false
Expand Down
26 changes: 0 additions & 26 deletions v3/newrelic/config_options.go
Original file line number Diff line number Diff line change
Expand Up @@ -252,32 +252,6 @@ func ConfigAppLogForwardingLabelsExclude(labelType ...string) ConfigOption {
}
}

//func ConfigAppLogCustomTagEnabled(enabled bool) ConfigOption {
// return func(cfg *Config) {
// cfg.ApplicationLogging.CustomTags.Enabled = enabled
// }
//}
//
//func ConfigAppLogCustomTagAddTagMap(tags map[string]string) ConfigOption {
// return func(cfg *Config) {
// // if cfg.ApplicationLogging.CustomTags == nil {
// // cfg.ApplicationLogging.CustomTags.Tags = make(map[string]string)
// // }
// for k, v := range tags {
// cfg.ApplicationLogging.CustomTags.Tags[k] = v
// }
// }
//}
//
//func ConfigAppLogCustomTagAddTag(label, tag string) ConfigOption {
// return func(cfg *Config) {
// // if cfg.ApplicationLogging.CustomTags == nil {
// // cfg.ApplicationLogging.CustomTags.Tags = make(map[string]string)
// // }
// cfg.ApplicationLogging.CustomTags.Tags[label] = tag
// }
//}

// ConfigAppLogDecoratingEnabled enables or disables the local decoration
// of logs when using one of our logs in context plugins
// Defaults: enabled=false
Expand Down

0 comments on commit fd9a62b

Please sign in to comment.