-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mobile): Flutter doc improvements #18513
Conversation
Hi @ally-sassman 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes). |
✅ Deploy Preview for docs-website-netlify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
...content/docs/mobile-monitoring/new-relic-mobile-flutter/monitor-your-flutter-application.mdx
Outdated
Show resolved
Hide resolved
…nitor-your-flutter-application.mdx
...content/docs/mobile-monitoring/new-relic-mobile-flutter/monitor-your-flutter-application.mdx
Show resolved
Hide resolved
...content/docs/mobile-monitoring/new-relic-mobile-flutter/monitor-your-flutter-application.mdx
Outdated
Show resolved
Hide resolved
...ring/new-relic-mobile-ionic-capacitor/get-started/introduction-new-relic-ionic-capacitor.mdx
Outdated
Show resolved
Hide resolved
...ring/new-relic-mobile-ionic-capacitor/get-started/introduction-new-relic-ionic-capacitor.mdx
Outdated
Show resolved
Hide resolved
The merge-base changed after approval.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Found some minor things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ally-sassman, I added some suggestions! Feel free to take them or leave them🙂
...content/docs/mobile-monitoring/new-relic-mobile-flutter/monitor-your-flutter-application.mdx
Outdated
Show resolved
Hide resolved
...content/docs/mobile-monitoring/new-relic-mobile-flutter/monitor-your-flutter-application.mdx
Outdated
Show resolved
Hide resolved
...ring/new-relic-mobile-ionic-capacitor/get-started/introduction-new-relic-ionic-capacitor.mdx
Outdated
Show resolved
Hide resolved
|
||
1. Include the New Relic Maven repository URL in the Gradle build settings. To do this, open your `mainTemplate.gradle` file. This file is usually located in the `Assets/Plugins/Android` folder. Now, open the New Relic Maven URL like this: | ||
1. In your Gradle build settings, you'll need to include the New Relic Maven repository URL. To do this, open your `mainTemplate.gradle` file, which is usually located in the `Assets/Plugins/Android` folder. Add the following snippet: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be possible to add the link to this repository?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great catch! Let me get it from the SME
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ndesai-newrelic Can you provide what the repo URL should be?
src/content/docs/mobile-monitoring/new-relic-mobile-unity/monitor-your-unity-application.mdx
Outdated
Show resolved
Hide resolved
...obile-monitoring/new-relic-monitoring-react-native/monitor-your-react-native-application.mdx
Outdated
Show resolved
Hide resolved
The merge-base changed after approval.
The merge-base changed after approval.
This PR covers some improvements to the Flutter docs, discovered during my mobile demo earlier this summer.
Jira: NR-296215