Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mobile): Flutter doc improvements #18513

Merged
merged 6 commits into from
Sep 6, 2024
Merged

Conversation

ally-sassman
Copy link
Contributor

@ally-sassman ally-sassman commented Aug 28, 2024

This PR covers some improvements to the Flutter docs, discovered during my mobile demo earlier this summer.

Jira: NR-296215

@ally-sassman ally-sassman added content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers labels Aug 28, 2024
@ally-sassman ally-sassman self-assigned this Aug 28, 2024
Copy link

Hi @ally-sassman 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

We will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 10 to 20 minutes).

Copy link

netlify bot commented Aug 28, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 1a8130d
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/66d8f67fdf293c0008ef47bd
😎 Deploy Preview https://deploy-preview-18513--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ally-sassman ally-sassman requested a review from nbaenam September 3, 2024 21:27
@ally-sassman ally-sassman marked this pull request as ready for review September 3, 2024 21:27
@github-actions github-actions bot requested a review from paperclypse September 3, 2024 21:28
@ally-sassman ally-sassman dismissed paperclypse’s stale review September 3, 2024 21:46

The merge-base changed after approval.

paperclypse
paperclypse previously approved these changes Sep 3, 2024
Copy link
Contributor

@paperclypse paperclypse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Found some minor things

nbaenam
nbaenam previously approved these changes Sep 4, 2024
Copy link
Contributor

@nbaenam nbaenam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ally-sassman, I added some suggestions! Feel free to take them or leave them🙂


1. Include the New Relic Maven repository URL in the Gradle build settings. To do this, open your `mainTemplate.gradle` file. This file is usually located in the `Assets/Plugins/Android` folder. Now, open the New Relic Maven URL like this:
1. In your Gradle build settings, you'll need to include the New Relic Maven repository URL. To do this, open your `mainTemplate.gradle` file, which is usually located in the `Assets/Plugins/Android` folder. Add the following snippet:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be possible to add the link to this repository?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great catch! Let me get it from the SME

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndesai-newrelic Can you provide what the repo URL should be?

@ally-sassman ally-sassman dismissed nbaenam’s stale review September 4, 2024 11:15

The merge-base changed after approval.

@nbaenam nbaenam self-requested a review September 4, 2024 11:16
nbaenam
nbaenam previously approved these changes Sep 4, 2024
@ally-sassman ally-sassman dismissed nbaenam’s stale review September 4, 2024 17:29

The merge-base changed after approval.

@ally-sassman ally-sassman merged commit 394ad1f into develop Sep 6, 2024
20 checks passed
@ally-sassman ally-sassman deleted the flutter-improvements branch September 6, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content requests related to docs site content from_tw Identifies issues/PRs from Tech Docs writers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants