-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add action to merge main into i18n branches #16129
Conversation
Hi @LizBaker 👋 Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days. Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes). |
✅ docs-website-develop deploy preview ready
|
❌ docs-website-develop deploy preview failedYour build failed. View the build logs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! i'm excited to see this in action
types: | ||
- closed | ||
paths: | ||
- '**.mdx' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we wanna check for .md
too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-we don't have any md files that go to translation at the moment 😭 - oh wait, but they could be added, i see i see yep. maybe we actually just want any newly added file?
); | ||
|
||
const sitesToBuild = getSitesToBuild(prFileData); | ||
try { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it might be good to have these in their own try/catch blocks so we they can succeed/fail independently and we could potentially see both error messages
✅ Deploy Preview for docs-website-netlify ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This action will check the files from the last PR to main and determine if a new english file has been added or if i18n files have been modified or added.
would love to refactor because it's not particularly dynamic at the moment 😜
(checks are failing because this relies on our impending bump to node 18)