Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action to merge main into i18n branches #16129

Merged
merged 5 commits into from
Feb 13, 2024
Merged

Conversation

LizBaker
Copy link
Contributor

@LizBaker LizBaker commented Feb 9, 2024

This action will check the files from the last PR to main and determine if a new english file has been added or if i18n files have been modified or added.

would love to refactor because it's not particularly dynamic at the moment 😜

(checks are failing because this relies on our impending bump to node 18)

@LizBaker LizBaker requested review from a team, clarkmcadoo and tabathadelane and removed request for a team February 9, 2024 19:57
@github-actions github-actions bot added the eng issues related to site functionality that requires engineering label Feb 9, 2024
Copy link

github-actions bot commented Feb 9, 2024

Hi @LizBaker 👋

Thanks for your pull request! Your PR is in a queue, and a writer will take a look soon. We generally publish small edits within one business day, and larger edits within three days.

Gatsby Cloud will automatically generate a preview of your request, and will comment with a link when the preview is ready (usually 20 to 30 minutes).

Copy link

gatsby-cloud bot commented Feb 9, 2024

✅ docs-website-develop deploy preview ready

Copy link

gatsby-cloud bot commented Feb 9, 2024

❌ docs-website-develop deploy preview failed

Your build failed. View the build logs.

Copy link
Contributor

@sunnyzanchi sunnyzanchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! i'm excited to see this in action

types:
- closed
paths:
- '**.mdx'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we wanna check for .md too?

Copy link
Contributor Author

@LizBaker LizBaker Feb 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-we don't have any md files that go to translation at the moment 😭 - oh wait, but they could be added, i see i see yep. maybe we actually just want any newly added file?

);

const sitesToBuild = getSitesToBuild(prFileData);
try {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be good to have these in their own try/catch blocks so we they can succeed/fail independently and we could potentially see both error messages

Copy link

netlify bot commented Feb 12, 2024

Deploy Preview for docs-website-netlify ready!

Name Link
🔨 Latest commit 2b792dd
🔍 Latest deploy log https://app.netlify.com/sites/docs-website-netlify/deploys/65caa567b029500009834780
😎 Deploy Preview https://deploy-preview-16129--docs-website-netlify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@LizBaker LizBaker merged commit 982ea65 into develop Feb 13, 2024
@LizBaker LizBaker deleted the liz/i18n-update-action branch February 13, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
eng issues related to site functionality that requires engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants