Make nr_tags optional #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation states that the field nr_tags is optional. But the terraform code requires you to specify the field. Documentation: https://docs.newrelic.com/docs/logs/forward-logs/aws-lambda-sending-cloudwatch-logs/ Error without setting the nr_tags field: ➜ terraform plan ╷ │ Error: Missing required argument │ │ on main.tf line 21, in module "newrelic_log_ingestion": │ 21: module "newrelic_log_ingestion" { │ │ The argument "nr_tags" is required, but no definition was found. This commit adds a default value, so that the field is actually optional as stated in the documentation.
|
|
|
Hi @adiesner , do we know if this is getting merged anytime soon? You're right, this should be optional |
Sadly I have no idea. I never heard anything back from them besides an automated email from the CLAassistant. I will get in touch with my contact at NewRelic and ask what is missing. |
|
@jcsobrino please merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation states that the field nr_tags is optional. But the
terraform code requires you to specify the field.
Documentation: https://docs.newrelic.com/docs/logs/forward-logs/aws-lambda-sending-cloudwatch-logs/
Error without setting the nr_tags field:
This commit adds a default value, so that the field is actually optional
as stated in the documentation.