Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DotnetWindowsInjector #1

Merged
merged 1 commit into from
Oct 29, 2024
Merged

feat: DotnetWindowsInjector #1

merged 1 commit into from
Oct 29, 2024

Conversation

andrew-lozoya
Copy link

Description

This update introduces a DotnetWindowsInjector for injecting New Relic .NET instrumentation into Windows-based containers within Kubernetes. The injection includes support for both .NET Framework and .NET Core applications.

Key features:

  • Automatically configures necessary environment variables for Windows .NET profiling and instrumentation paths.
  • Ensures that the required Windows path volumes and nanoserver based init containers are properly set up for instrumentation files.
  • Includes error handling to prevent duplicate environment variable settings if instrumentation is already configured.

Additionally, this PR adds a GitHub Actions workflow to automate the build and publication of Docker images for the instrumentation, targeting Windows Server 2019 and 2022. As well as updated chart helper functions.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ X] New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • [X ] Documentation has been updated
  • [ X] This change requires changes in testing:
    • [ X] unit tests
    • [ X] E2E tests

@andrew-lozoya andrew-lozoya merged commit 52755cb into main Oct 29, 2024
3 checks passed
@andrew-lozoya andrew-lozoya changed the title DotnetWindowsInjector feat: DotnetWindowsInjector Oct 30, 2024
@andrew-lozoya andrew-lozoya self-assigned this Oct 30, 2024
Copy link

@pnvnd pnvnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants