Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MRZ landscape crash #155

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Fix MRZ landscape crash #155

merged 1 commit into from
Oct 30, 2023

Conversation

jlduragos
Copy link
Contributor

@jlduragos jlduragos commented Oct 30, 2023 •
edited
Loading

Issue

##144 MRZ reading in landscape crash

Changes

1.Add missing element in landscape layout
2.Ignore post block if viewFinder.display is null

@jlduragos jlduragos requested a review from megaxayda October 30, 2023 07:32
megaxayda
megaxayda approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@megaxayda megaxayda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlduragos jlduragos merged commit 507ce07 into develop Oct 30, 2023
1 check passed
@jlduragos jlduragos deleted the fix/mrz-landscape-crash branch October 30, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@megaxayda megaxayda megaxayda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jlduragos @megaxayda