Added Rails4 compatibility #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent versions of shoulda-matchers (apparently) have removed the respond_with_content_type matcher. I only guess so because I can't find it in the current version. Therefore I've replaced those tests with (imho) suitable replacement matchers.
|
Note: there is an issue with Ruby 2.0, where it doesn't recognize |
|
@tylergannon were you able to resolve this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few things have moved around in recent versions of minitest-rails... see https://github.com/blowmage/minitest-rails/wiki/Upgrading-to-0.9 for details.
Also,
Recent versions of shoulda-matchers (apparently) have removed the
respond_with_content_type matcher. I only guess so because I can't
find it in the current version. Therefore I've replaced those tests
with (imho) suitable replacement matchers.
I doubt you'll want to merge this pull request with master... but I wanted to show you this work in case you're ready to add a rails4 branch.