Test: handler-resolver.ts tests + adding tests to github actions workflow #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
namanaman
reviewed
Feb 21, 2024
src/libs/handler-resolver.test.ts
Outdated
| @@ -0,0 +1,63 @@ | |||
| import { handlerPath } from './handler-resolver'; | |||
|
|
|||
| describe('handlerPath success cases', () => { | |||
There was a problem hiding this comment.
Hmm I sort of feel like structurally, it makes more sense to have 1 describe block for the "handlerPath function" and then nested within THAT are 2 different it.each blocks for success and error. What do you think?
There was a problem hiding this comment.
Updated to nest it in a describe block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for libs/handler-resolver.ts + updated ci.yml to include running tests