Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Performance to 2.5.0 #910

Closed
wants to merge 1 commit into from
Closed

Conversation

arunshenoy99
Copy link
Member

Proposed changes

  1. Clean up code to follow code standards
  2. Add Health Checks
  3. Fix: avoid useless loading of scripts
  4. Fix Skip 404 settings appearance
  5. Fix missing styles on the Brand Plugin dashboard

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Videos/Screenshots are in the individual PRs.

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@arunshenoy99 arunshenoy99 changed the base branch from main to develop January 29, 2025 13:09
@arunshenoy99 arunshenoy99 changed the title Update/performance 2.5.0 Bump Performance to 2.5.0 Jan 29, 2025
Copy link

cypress bot commented Jan 29, 2025

HostGator Plugin    Run #5762

Run Properties:  status check passed Passed #5762  •  git commit d5d28f2653 ℹ️: Merge ecafb34e88162d1bffc8285e21564385542e779a into a7a7276bffc0ecc7d31d63b8566d...
Project HostGator Plugin
Branch Review update/performance-2.5.0
Run status status check passed Passed #5762
Run duration 26m 15s
Commit git commit d5d28f2653 ℹ️: Merge ecafb34e88162d1bffc8285e21564385542e779a into a7a7276bffc0ecc7d31d63b8566d...
Committer Arun Shenoy
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 26
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 305
View all changes introduced in this branch ↗︎

Copy link

cypress bot commented Jan 29, 2025

HostGator Plugin    Run #5759

Run Properties:  status check passed Passed #5759  •  git commit ecafb34e88: Bump Performance to 2.5.0
Project HostGator Plugin
Branch Review update/performance-2.5.0
Run status status check passed Passed #5759
Run duration 28m 05s
Commit git commit ecafb34e88: Bump Performance to 2.5.0
Committer arunshenoy99
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 28
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 313
View all changes introduced in this branch ↗︎

@circlecube circlecube added this to the February 5, 2025 Release milestone Jan 30, 2025
@circlecube
Copy link
Member

@arunshenoy99 if a module update does not require any plugin changes we can rely on the dependabot PR for it. Depednabot PRs are preferred because they will resolve lock file conflicts automatically.

If there is not a dependabot PR yet and the deadline window to get the module update into a plugin release feel free to create one. But since I already merged the dependabot PR I'll close this one.

@circlecube circlecube closed this Jan 30, 2025
@circlecube circlecube deleted the update/performance-2.5.0 branch January 30, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants