-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Action to deploy and test the plugin in a target environment #64
base: main
Are you sure you want to change the base?
Conversation
Note: before merging the PR we can change the tests that will be run while its execution and the environments. At the moment the Cypress test that will be ran is just one from the integration folder that perform simple checks. Both changes can be done just editing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Once we get this deployed, we'll start writing some live tests for onboarding.
- name: Setup Node.js | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: 18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update this to use Node 20, like the plugin does. See https://github.com/newfold-labs/wp-plugin-bluehost/blob/main/.nvmrc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated to use Node v20
- name: Cleanup SSH Key | ||
run: rm -f github-actions | ||
|
||
- name: Wait for Server to be Ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a note here about the purpose of this waiting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the name of the Step in "Check if the remote Server is up" as it just checks if the site_url in which should be run the cypress test is reachable
Updated step name
Proposed changes
See: PRESS0-1986
This PR introduces a new GitHub Action workflow to automate the deployment and testing of the plugin in a specified environment.
The workflow follows these steps:
Type of Change
Production
Development
Video
Checklist
Further comments