Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the Lint workflow to use PHP 8.2 #53

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Conversation

mr-vara
Copy link
Contributor

@mr-vara mr-vara commented Feb 18, 2025

Proposed changes

Description:

This PR updates the GitHub workflow to use PHP 8.2 to resolve compatibility issues with symfony/finder and wp-cli/wp-cli.

Changes:

  • Updated the GitHub Actions workflow to set up PHP 8.2.
  • Ensured compatibility with dependencies that require PHP >=8.2.

Reason for Change:

Previously, the workflow was using PHP 7.4, which caused dependency conflicts, particularly with symfony/finder v7.2.2, which requires PHP 8.2. This resulted in the following error:

Your lock file does not contain a compatible set of packages. Please run composer update.

By updating the workflow to use PHP 8.2, these conflicts are resolved without modifying the composer.json or composer.lock files.

Impact:

  • Fixes build failures in GitHub Actions.
  • Ensures compatibility with required PHP versions.

@mr-vara mr-vara requested a review from wpscholar February 18, 2025 17:01
wpscholar
wpscholar previously approved these changes Feb 18, 2025
@mr-vara mr-vara merged commit 98fa0b4 into main Feb 18, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants