Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Skip 404 and Link Prefetch settings appearance #80

Closed
wants to merge 1 commit into from

Conversation

bradp
Copy link
Contributor

@bradp bradp commented Jan 23, 2025

Proposed changes

Makes the settings screen more consistent.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Screenshots

Before:

link-prefetch-before
skip-404-before

After:

link-prefetch
skip-404

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added necessary documentation (if appropriate)

@geckod22
Copy link
Contributor

@bradp for me would be ok, but about Link Prefecth toggle, I remember Chros told to put them like that.

@bradp
Copy link
Contributor Author

bradp commented Jan 27, 2025

@bradp for me would be ok, but about Link Prefecth toggle, I remember Chros told to put them like that.

Split this PR into #90 and #91 so that we can handle them separately!

@bradp bradp closed this Jan 27, 2025
@bradp bradp deleted the fix/fix-skip404-link-prefetch-settings-screen branch January 27, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants