Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Optimization Tests - AQA-6911 #78

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

krsomayagi
Copy link

Proposed changes

Performance module
Image optimization features automated

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link
Member

@arunshenoy99 arunshenoy99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krsomayagi I don’t think these tests will work because CF cannot connect to the GitHub runner hosting a local WordPress instance. This is similar to how you can’t test Image Optimization on your localhost without setting up port forwarding.

@arunshenoy99 arunshenoy99 changed the title Performance module- Image optimization-AQA-6911 Image Optimization Test - AQA-6911 Jan 27, 2025
@arunshenoy99 arunshenoy99 changed the title Image Optimization Test - AQA-6911 Image Optimization Tests - AQA-6911 Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants