Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache: Hide Admin Bar Menu When Cache is Disabled #108

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

arunshenoy99
Copy link
Member

Proposed changes

This PR hides the caching option in the admin bar when caching is turned off.

output.mp4

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@geckod22
Copy link
Contributor

@arunshenoy99 If I remeber good, that menu on top should be always present as it is not connected with the cache level in the performance panel. The performance panel cache level only write to the htaccess, while the purgeall is I think connected with cloudflare thing or other purgeable caches that could be available by server setting. Indeed before there was a check about that and Chris told that the check was not needed anymore. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants