Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scope this * selector to #nfd-installer elements #77

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

circlecube
Copy link
Member

Proposed changes

While debugging onboarding today, I noticed this star selector setting some styles broadly across the whole wp-admin. We should avoid doing this as these styles are not scoped to the component in this module but every element. I noticed it because it interfers with some elements rendering properly in the onboarding fork screen.

We removed a body font-family tag earlier in this file (see #54) and now I'm noticing this. Are these styles needed? Can we use selectors to target specifically what needs the styles rather than a *? This stylesheet is loaded across the whole wp-admin.

Before merging, I (or anyone) should ideally take some time and update it to use more specific selectors; this is just a quick change to get the conversation started.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant