scope this * selector to #nfd-installer elements #77
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
While debugging onboarding today, I noticed this star selector setting some styles broadly across the whole wp-admin. We should avoid doing this as these styles are not scoped to the component in this module but every element. I noticed it because it interfers with some elements rendering properly in the onboarding fork screen.
We removed a body font-family tag earlier in this file (see #54) and now I'm noticing this. Are these styles needed? Can we use selectors to target specifically what needs the styles rather than a
*
? This stylesheet is loaded across the whole wp-admin.Before merging, I (or anyone) should ideally take some time and update it to use more specific selectors; this is just a quick change to get the conversation started.
Type of Change
Production
Development
Video
Checklist
Further comments