Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Localisation Support #92

Merged
merged 22 commits into from
Feb 26, 2025
Merged

Add Localisation Support #92

merged 22 commits into from
Feb 26, 2025

Conversation

mr-vara
Copy link
Contributor

@mr-vara mr-vara commented Feb 14, 2025

Proposed changes

Important: I am currently working on adding translations to the modules as part of this EPIC: https://jira.newfold.com/browse/PRESS11-144. My primary focus is on integrating translations and setting up the automation workflow.
As part of this effort, I am adding the essential components required to load text domains and register translation paths for both PHP strings and JS scripts.
Please feel free to build upon this work, particularly in terms of fully handling the loading of translations within the module.

This pull request adds translation and localization support to the WordPress Help Center module. All user-facing text strings have been updated using WordPress internationalization (i18n) functions, ensuring that the module can be translated into various languages. This update improves accessibility and usability for a global audience, adhering to WordPress localization standards.

Key changes include:

  • Implemented WordPress i18n functions (__(), _e(), etc.) across all strings.
  • Added a .pot file for translation string management.
  • Updated plugin files to enable smooth and consistent localization.

With this enhancement, the Help Center module can be translated into multiple languages, offering better support to non-English speaking users and broadening its usability.

Copy link
Member

@wpscholar wpscholar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also add a workflow for our linting

@mr-vara mr-vara requested a review from wpscholar February 20, 2025 11:55
@mr-vara mr-vara requested a review from ajayadav09 February 24, 2025 10:43
ajayadav09

This comment was marked as duplicate.

Co-Authored-By: Emanuela Antonina Castorina  <[email protected]>
@ajayadav09
Copy link
Contributor

@mr-vara @circlecube Updated the PR with a few changes for the JS translations to load. Please go through them.

abhijitb
abhijitb previously approved these changes Feb 25, 2025
Copy link
Contributor

@abhijitb abhijitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested is locally for the Spanish and French languages ... attaching screenshots ... looks good
help-center-french
help-center-spanish

ajayadav09
ajayadav09 previously approved these changes Feb 25, 2025
abhijitb
abhijitb previously approved these changes Feb 25, 2025
@mr-vara mr-vara dismissed stale reviews from abhijitb and ajayadav09 via 9a27b28 February 25, 2025 14:21
@circlecube circlecube self-requested a review February 25, 2025 22:06
@circlecube circlecube merged commit 71e1979 into main Feb 26, 2025
2 of 3 checks passed
@circlecube circlecube deleted the press11-165 branch February 26, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants