Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRESS0-2648 || Module ecommerce: translation audit #434

Closed
wants to merge 2 commits into from

Conversation

ramyakrishnai
Copy link
Contributor

@ramyakrishnai ramyakrishnai commented Feb 17, 2025

Screenshot 2025-02-17 at 5 43 34 PM

Changes

  • Added missing translations
  • Removed the repeated lines from ecommerce.php file
  • Renaming the files in language folder to mach the slug which is used to register the script to make translations work

Proposed changes

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link
Member

@wpscholar wpscholar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still seeing some strings that aren't translated. We should manually review each file to make sure we're not missing any strings.

For example:

@circlecube circlecube mentioned this pull request Feb 20, 2025
@circlecube
Copy link
Member

I manually pulled this PR into #433 since they both deal with translations. I then updated the all caps strings and removed some extra whitespace in other strings. Then updated the build files and regenerated the i18n files in that PR.

@circlecube
Copy link
Member

As it was manually merged into the other translation branch, I'll close this one.

@circlecube circlecube closed this Feb 26, 2025
@circlecube circlecube deleted the fix/PRESS0-2468 branch February 26, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants