Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update module test for the nav class cleanForSlug change #432

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

circlecube
Copy link
Member

Proposed changes

This updates the nav item class selector in the test to be compatible with this change: newfold-labs/wp-plugin-bluehost#47

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube self-assigned this Feb 13, 2025
@circlecube circlecube requested a review from wpscholar February 13, 2025 22:22
@circlecube circlecube merged commit fafa9c9 into trunk Feb 13, 2025
1 of 4 checks passed
@circlecube circlecube deleted the update/tests branch February 13, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants