Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize ecomdash image - brings module size down 1MB #402

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

circlecube
Copy link
Member

Proposed changes

At some point, a very large image was brought into this module. I optimized it from 1 MB down to 83k. Not seeing a noticeable difference in quality, but please check.

See jira ticket PRESS10-26 for more details.

Type of Change

Production

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update
  • Refactoring / housekeeping (changes to files not directly related to functionality)

Development

  • Tests
  • Dependency update
  • Environment update / refactoring
  • Documentation Update

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

this brings the image down from 1Mb to 83k
@circlecube circlecube merged commit a16e9b1 into trunk Jan 8, 2025
2 of 4 checks passed
@circlecube circlecube deleted the update/ecom-image branch January 8, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants