Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/solutions abtest flag for displaying solutions banner component #369

Conversation

circlecube
Copy link
Member

Proposed changes

This adds a capability check for abTestSolutionsActive and sets a canSolution value. This way we can release a plugin without any solutions displaying on the plugin home screen until they are ready across the board.

While I was in the file I fixed some lint/whitespace issues, and then saw some complex ternary values and rewrote as a switch statement for clarity. I removed i18n translations of dynamic strings, since they'll soon be coming from an API, we won't be translating them anyway. Some other minor code cleanup and a version bump to 1.4.1.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube self-assigned this Oct 23, 2024
@circlecube
Copy link
Member Author

Sorry for the amount of whitespace changes! It may be a good time to use the "Hide whitespace" feature in the diff view. It auto fixed, and was much easier to read so I ran with it.

I've tested these changes with abTestSolutionsLaunched set to false and true as well as with hasSolution capability true and false, and each solution assigned to ensure the switch statement functions properly and displays the proper cards.

@circlecube circlecube merged commit 3ed0abe into trunk Oct 23, 2024
5 checks passed
@circlecube circlecube deleted the add/solutions-abtest-flag-for-displaying-solutions-banner-component branch October 23, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants