Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/solutions buttons #367

Closed
wants to merge 4 commits into from
Closed

Conversation

circlecube
Copy link
Member

Proposed changes

This PR updates the rendering of the buttons to be more consistent by using the new installer module renderInstallerButton helper method.

It also cleans up the constants used in the plugin app solutions banner so their shape more resembles the entitlements shape and fills in some missing data, cleans up the code, removes commented-out console statements, and removes other now unused code.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Video

Checklist

  • I have read the CONTRIBUTING doc
  • I have viewed my change in a web-browser
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube requested a review from wpscholar October 22, 2024 04:35
@circlecube
Copy link
Member Author

Closing as we're not focusing on this currently

@circlecube circlecube closed this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant