Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRESS0-1256 Remove text dependency, Replace text identifiers with id #297

Merged
merged 7 commits into from
May 16, 2024
Merged

PRESS0-1256 Remove text dependency, Replace text identifiers with id #297

merged 7 commits into from
May 16, 2024

Conversation

sangeetha-nayak
Copy link
Contributor

@sangeetha-nayak sangeetha-nayak commented Apr 25, 2024 •
edited
Loading

Proposed changes

PRESS0-1256 | Remove Text assertions from cypress tests to make tests language agnostic. Replaced text identifiers with other unique identifiers such as ID.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

This issue #255 will be addressed as part of this PR.

@aratidgr8
Copy link
Contributor

@sangeetha-nayak
Please add task details & JIRA link in PR description

ramyakrishnai
ramyakrishnai previously approved these changes May 3, 2024
View reviewed changes
diwanshuster
diwanshuster previously approved these changes May 3, 2024
View reviewed changes
@ramyakrishnai ramyakrishnai requested review from aratidgr8 and removed request for aratidgr8 May 3, 2024 09:42
@sangeetha-nayak sangeetha-nayak dismissed stale reviews from diwanshuster and ramyakrishnai via a6b105a May 6, 2024 06:27
@sangeetha-nayak sangeetha-nayak merged commit 0dbbac2 into trunk May 16, 2024
3 of 5 checks passed
@sangeetha-nayak sangeetha-nayak deleted the PRESS0-1256 branch May 16, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diwanshuster diwanshuster diwanshuster approved these changes

@aratidgr8 aratidgr8 aratidgr8 approved these changes

@ramyakrishnai ramyakrishnai ramyakrishnai left review comments

Assignees
No one assigned
Labels
Code Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sangeetha-nayak @aratidgr8 @diwanshuster @ramyakrishnai