Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Cannot modify header information warning due to PRESS4-508 code … #282

Merged
merged 1 commit into from
Apr 19, 2024
Merged

Fix Cannot modify header information warning due to PRESS4-508 code … #282

merged 1 commit into from
Apr 19, 2024

Conversation

aratidgr8
Copy link
Contributor

Proposed changes

Fix for PHP Warning: Cannot modify header information - headers already sent in /Users/arati.b/Desktop/wp-module-ecommerce/includes/ECommerce.php on line 197 due to PRESS4-508 code changes.

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

diwanshuster
diwanshuster approved these changes Apr 15, 2024
View reviewed changes
Copy link

@diwanshuster diwanshuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@manikantakailasa manikantakailasa merged commit 465f142 into trunk Apr 19, 2024
1 of 6 checks passed
@manikantakailasa manikantakailasa deleted the php-warning-fix-wpnavbar branch April 19, 2024 09:55
@manikantakailasa manikantakailasa mentioned this pull request Apr 19, 2024
Merged
@ramyakrishnai ramyakrishnai mentioned this pull request Apr 19, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diwanshuster diwanshuster diwanshuster approved these changes

@mamatharao05 mamatharao05 Awaiting requested review from mamatharao05

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aratidgr8 @diwanshuster @manikantakailasa