Facebook chnages #179
Facebook chnages #179
Conversation
package.json
Outdated
| @@ -24,6 +24,7 @@ | |||
| "@newfold-labs/js-utility-ui-analytics": "^1.2.0", | |||
| "@newfold-labs/wp-module-runtime": "^1.0.0", | |||
| "@newfold/ui-component-library": "^1.0.0", | |||
| "@newfold/wp-module-facebook": "file:../wp-module-facebook", | |||
There was a problem hiding this comment.
Looks like this will need to be updated before release
There was a problem hiding this comment.
yes, we'll update it before the release.
| if ( ! $hiive_token ) {} | ||
| return new \WP_REST_Response( | ||
| array( | ||
| 'token' => $hiive_token ? $hiive_token : 'test2', |
There was a problem hiding this comment.
We should probably just return an empty string instead of test2?
There was a problem hiding this comment.
We're storing it as Key value pair in cloudflare and as key can't be blank. In local, as we don't have a hiiive_token .So, we've added a placeholder variable as test2
| array( | ||
| array( | ||
| 'methods' => \WP_REST_Server::READABLE, | ||
| 'callback' => array( $this, 'get_hiive_token' ), |
There was a problem hiding this comment.
Where are we using this API? I'm uneasy about passing a Hiive token to the front end.
There was a problem hiding this comment.
this endpoint we're using it in facebook module to store facebook token against hiive token as key-value pair in cloudflare
No description provided.