Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace the materials crate #2652

Merged
merged 9 commits into from
Jan 10, 2025

Conversation

dvir001
Copy link
Contributor

@dvir001 dvir001 commented Jan 3, 2025

About the PR

Place holder for cargo that isnt used anymore
Replaced it with a new locker

Why / Balance

It was added to offer a cargo option to buy general materials in a single crate, but no longer used in cargo.
Now replaced with a version that match the wall version

How to test

N/A

Media

image

image

Requirements

Breaking changes

N/A

Changelog
N/A

@github-actions github-actions bot added No C# YML Status: Needs Review This PR is awaiting reviews labels Jan 3, 2025
@arimah
Copy link
Contributor

arimah commented Jan 3, 2025

I'm not sure how I feel about this. It's married on a small number of ships to help bootstrap production without the need to do mining and salvage. The intention there is to discourage people from just getting everything themselves, such that when their starter material is running low, they can buy more from someone else.

@dvir001
Copy link
Contributor Author

dvir001 commented Jan 3, 2025

I'm not sure how I feel about this. It's married on a small number of ships to help bootstrap production without the need to do mining and salvage. The intention there is to discourage people from just getting everything themselves, such that when their starter material is running low, they can buy more from someone else.

Charon - Can get in the mats without it
Hammer - Can get in the mats without it
Lyrae - Can get in the mats without it

This 3 ships will be find without the full stacks of:
Glass, Plastic, Steel, Plasma and Plasteel mapped

@arimah
Copy link
Contributor

arimah commented Jan 3, 2025

We already have the materials wall locker, which contains steel, plastic, glass and wood. That comes standard on many service ships. I think we could easily transform this materials crate into having just steel, plastic and glass, just so you can print a small number of basic things while others get busy collecting stuff for you to buy.

@dvir001
Copy link
Contributor Author

dvir001 commented Jan 3, 2025

We already have the materials wall locker, which contains steel, plastic, glass and wood. That comes standard on many service ships. I think we could easily transform this materials crate into having just steel, plastic and glass, just so you can print a small number of basic things while others get busy collecting stuff for you to buy.

If anything I can map one on the ships here (Except Charon) and add a picture here for the logical location, should be next to where the crate is.

Trying to save on entity we upkeep when we have a marked locker for mats everyone know about by now.

Stacks of 10 or the full 30?

Copy link
Contributor

github-actions bot commented Jan 4, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the Merge Conflict This PR has conflicts that prevent merging label Jan 4, 2025
@github-actions github-actions bot removed the Merge Conflict This PR has conflicts that prevent merging label Jan 4, 2025
@GreaseMonk
Copy link
Contributor

GreaseMonk commented Jan 6, 2025

dont merge yet

@dvir001 can you keep the prototype but remove the cargo one, lets keep it on the ships for now as a alternative for wall locker mapping

@dustylens
Copy link
Contributor

I believe we're nearing a final point for the ship standards moving forward.

It would be good to have the matter of chests of materials vs lockers settled definitively before then.

@arimah
Copy link
Contributor

arimah commented Jan 6, 2025

It would be good to have the matter of chests of materials vs lockers settled definitively before then.

The definitive answer is I'd like to have options! Wall lockers don't fit everywhere, space-wise or aesthetically, and it's nice to be able to pick a crate when it makes more sense.

@dustylens
Copy link
Contributor

Codified + consistent = contented

@dvir001
Copy link
Contributor Author

dvir001 commented Jan 6, 2025

Finnneeee
Ill rebase the fill to the locker, and keep it for mapping, but this crate should have a new Sprite, right now using the normal steal sprite vs the locker having a cool sprite isn't great.

If anyone working or want to make a sprite ping me on discord about it.

@dvir001 dvir001 marked this pull request as draft January 6, 2025 15:03
@dustylens
Copy link
Contributor

Just make a pair of chests with the same fills as the wall lockers for mapping consistency? Does that need a unique sprite?

@dvir001
Copy link
Contributor Author

dvir001 commented Jan 6, 2025

Just make a pair of chests with the same fills as the wall lockers for mapping consistency? Does that need a unique sprite?

unique "tower/floor" locker sprite please.

@dustylens
Copy link
Contributor

Just make a pair of chests with the same fills as the wall lockers for mapping consistency? Does that need a unique sprite?

unique "tower/floor" locker sprite please.

If that's addressed to me I'd pack a lunch before waiting for that train to come into the station.

@dvir001
Copy link
Contributor Author

dvir001 commented Jan 8, 2025

@dvir001 dvir001 changed the title Remove the materials crate Replace the materials crate Jan 10, 2025
@dvir001 dvir001 marked this pull request as ready for review January 10, 2025 17:02
Copy link
Contributor

RSI Diff Bot; head commit 14e9caa merging into 709d121
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_NF/Structures/Storage/closet.rsi

State Old New Status
door-decal-engi-01 Added
door-decal-null Added
generic_open Added
secure Added
secure_door Added
secure_open Added

@dvir001
Copy link
Contributor Author

dvir001 commented Jan 10, 2025

I ended up making something else with the sprite, more simple based.

@dvir001 dvir001 merged commit 7848475 into new-frontiers-14:master Jan 10, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants